test: modernize config.t to Test::More#58
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
config.t was the last test file still using raw TAP output (print "ok N"). Convert to Test::More with proper ok() assertions and descriptive test names. Also remove the stale 'Test' dependency from cpanfile since all tests now use Test::More exclusively. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convert config.t from raw TAP output to Test::More — the last test file still using
print "ok N".Why
All other tests were modernized in PR #47. config.t was missed because it uses a different
testing pattern (spawning server children with config files). With this change, the entire test
suite uses Test::More consistently, and the stale
Testmodule dependency can be removed from cpanfile.How
print "${ok}ok N\n"withok()assertions and descriptive test namesplan tests => Nwith conditional count based on hostname resolutionundeffor numTests toChild()so Test::More owns the planuse warningsrequires 'Test' => '0'from cpanfileTesting
Full test suite passes (76 tests across 18 files, 3 ithread tests skipped on this system).
🤖 Generated with Claude Code