refactor: replace Symbol::gensym() with lexical filehandles#59
Draft
toddr-bot wants to merge 1 commit into
Draft
refactor: replace Symbol::gensym() with lexical filehandles#59toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
Remove all Symbol::gensym() calls (4 sites across 3 files) and use plain lexical scalars for filehandles instead. This drops the Symbol module dependency entirely. Note: $fh must be declared before compound open/print/close expressions because Perl's `my` inside `open(my $fh, ...)` is not visible to subsequent `and`/`||` operands in the same statement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove all
Symbol::gensym()usage and theSymbolmodule dependency from the codebase.Why
Symbol::gensym()was the pre-5.6 way to create anonymous filehandle references. Since Perl 5.6,plain lexical scalars (
my $fh) work as filehandles, making gensym unnecessary. This removes alegacy dependency and aligns with modern Perl idioms.
How
Daemon.pm,Log.pm, andTest.pmuse Symbol ()/require Symbolimports removed from all three filesmy $fhbefore compound open/print/close expressions(not inside
open()) to avoid the Perl scoping gotcha wheremyinside oneoperand of
and/||is invisible to subsequent operandsTesting
Full test suite passes (76 tests, 18 files).
🤖 Generated with Claude Code