fix: restore umask on Unix socket creation failure#60
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
If IO::Socket::UNIX->new() failed in Bind(), Fatal() would die before umask was restored from 0 to its original value. Any code catching the die (via eval) would continue with umask 0, making subsequently created files world-readable/writable. Fix: restore umask immediately after socket creation attempt, then check for failure separately. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix umask leak in Bind() when Unix socket creation fails.
Why
If
IO::Socket::UNIX->new()fails,Fatal()dies beforeumask $old_umaskexecutes.Any caller catching the die via
eval {}would continue running with umask 0, causingsubsequently created files to be world-readable/writable — a potential security issue.
How
Restore umask immediately after the socket creation attempt, then check for failure
and call Fatal() separately. The umask is always restored regardless of success or failure.
Testing
Full test suite passes. The Unix socket failure path is difficult to test in isolation
(requires simulating IO::Socket::UNIX failure), but the fix is a straightforward
reordering with no behavioral change on the success path.
🤖 Generated with Claude Code