fix: remove obsolete code and correct --version exit status#61
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: remove obsolete code and correct --version exit status#61toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
- Change --version from exit 1 to exit 0 (standard Unix convention)
- Remove deprecated Sys::Syslog::setlogsock('unix') call (no-op since
Sys::Syslog 0.15, and we require 0.29)
- Remove outdated "KNOWN PROBLEMS" POD section referencing a Perl bug
from year 2000 that was fixed in Sys::Syslog decades ago
- Drop stale Test module dependency from cpanfile (all tests migrated
to Test::More)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes dead code from the 1990s-2000s era and fixes an incorrect exit status.
Why
--versionexited with status 1, which signals failure to calling scripts/tools. Standard Unix convention is exit 0 for--version.Sys::Syslog::setlogsock('unix')has been a no-op since Sys::Syslog 0.15 (2006). We require 0.29. The OS-sniffing guard around it was cargo-cult from a 1990s workaround.cpanfilelistedTestas a test dependency, but all tests have been migrated toTest::More.How
Pure deletion + one
exit 1→exit 0change. No behavioral change except the exit code fix.Testing
Full test suite passes.
🤖 Generated with Claude Code
Quality Report
Changes: 3 files changed, 1 insertion(+), 25 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline