fix: harden Accept() against invalid regex masks#62
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
…ntity Invalid regex patterns in client mask configuration (e.g., from a misconfigured config file) would crash the daemon with an uncaught regex compilation error. Now masks are pre-compiled with qr// inside eval — invalid patterns are logged and skipped, following fail-closed semantics. Also handles gethostbyaddr() failures gracefully: when DNS lookup returns no results and peerhost() is unavailable, the connection is denied with a clear error rather than proceeding with an empty patterns list or triggering undef warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevents daemon crashes from invalid regex patterns in client mask configuration.
Why
A misconfigured
clientsmask (e.g.,*invalid[or(unclosed) causes an uncaught regex compilation error that kills the daemon process. This is a denial-of-service vector via config files and a common source of hard-to-diagnose production crashes.How
qr//insideeval— invalid patterns are logged viaError()and skippedgethostbyaddr()failures: when DNS returns nothing andpeerhost()is unavailable, deny with a clear error instead of proceeding with empty patterns or triggering undef warnings$fromformatting against undef peerhost/peerportTesting
New
t/accept-edge.twith 8 tests covering:Full test suite passes.
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 132 insertions(+), 6 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline