test: add constructor and utility method unit tests#65
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
Cover Net::Daemon->new() option parsing paths not exercised by existing tests: --childs forcing single mode, --nocatchint, unknown mode fatal, undef attr, non-option arg preservation, ReadConfigFile integration (valid config, CLI override, missing file, invalid content), Done() getter/setter, Version(), Options() keys, and SigChildHandler() return values per mode. 34 new tests in t/new.t. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
t/new.twith 34 tests coveringNet::Daemon->new()constructor paths and related utility methods.Why
Existing tests exercise the constructor indirectly through integration tests (server spawning), but many option-handling code paths in
new()had no direct coverage:--childsforcing single mode,--nocatchint, unknown mode error,ReadConfigFileintegration, and theDone()/SigChildHandler()utility methods.How
Unit tests that construct
Net::Daemonobjects directly with various attribute/option combinations, without spawning servers. Config file tests useFile::Tempfor isolation.Testing
All 34 new tests pass. Full test suite passes (
make test— 0 failures).Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Quality Report
Changes: 1 file changed, 271 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline