fix: handle fork failure gracefully in preforking mode#69
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
Replace die with Error + last when fork() fails during the preforking loop in Bind(). Previously a fork failure mid-loop would crash the parent and orphan already-forked children. Now the server logs the error, stops forking, and either continues with partial children or calls Fatal if zero children were created. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handle fork() failure in the preforking loop of Bind() without crashing the server.
Why
When
--childs=Nis used and fork() fails mid-loop (e.g., RLIMIT_NPROC), theprevious
die "Cannot fork: $!"crashed the parent process, orphaning anychildren that were already forked. This is the preforking counterpart to #64
which fixed the same class of bug in ChildFunc().
How
diewithError()+last— logs the failure and stops forkingFatal()(server can't operate)Testing
t/prefork_failure.t— usesCORE::GLOBAL::forkoverride to simulatefork failure without creating real child processes
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 157 insertions(+), 2 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline