Skip to content

Fix #11184 FN leakNoVarFunctionCall with assignment #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −4
Open

Fix #11184 FN leakNoVarFunctionCall with assignment #8567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aa7249
Update checkmemoryleak.cpp
chrchr-github May 20, 2026
ee311fc
Update testmemleak.cpp
chrchr-github May 20, 2026
bc5dece
Format
chrchr-github May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/checkmemoryleak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,10 +1022,8 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
const Token* tok2 = tok->next()->astParent();
while (tok2 && (tok2->isCast() || Token::Match(tok2, "?|:")))
tok2 = tok2->astParent();
if (Token::Match(tok2, "%assign%")) // TODO: check if function returns allocated resource
continue;
if (Token::simpleMatch(tok->astTop(), "return"))
continue;
const bool hasAssign = Token::Match(tok2, "%assign%");
const bool hasReturn = Token::simpleMatch(tok->astTop(), "return");

const std::string& functionName = tok->str();
if ((tok->isCpp() && functionName == "delete") ||
Expand All @@ -1037,6 +1035,12 @@ void CheckMemoryLeakNoVar::checkForUnreleasedInputArgument(const Scope *scope)
if (!tok->isKeyword() && !tok->function() && !mSettings->library.isLeakIgnore(functionName))
continue;

if ((hasAssign || hasReturn) && !tok->function()) {
const std::string& ret = mSettings->library.returnValueType(tok);
if (ret.empty() || endsWith(ret, "*"))
continue;
}

const std::vector<const Token *> args = getArguments(tok);
int argnr = -1;
for (const Token* arg : args) {
Expand Down
11 changes: 11 additions & 0 deletions test/testmemleak.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2603,6 +2603,17 @@ class TestMemleakNoVar : public TestFixture {
" a.g(new int);\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("int f() {\n" // #11184
" return strlen(new char[4]{});\n"
"}\n"
"int g() {\n"
" int i = strlen(new char[4]{});\n"
" return i;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2:19]: (error) Allocation with new, strlen doesn't release it. [leakNoVarFunctionCall]\n"
"[test.cpp:5:20]: (error) Allocation with new, strlen doesn't release it. [leakNoVarFunctionCall]\n",
errout_str());
}

void missingAssignment() {
Expand Down
Loading