[Based on #143] test/wasm: complete resumable ABI and debug acceptance - #144
Closed
cpunion wants to merge 5 commits into
Closed
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. |
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #143.
Completes the K4 acceptance layer from xgo-dev#2152 for the opt-in LLVM-coroutine wasm backend.
What changes
runtime.Callersand pclntab lookup still work after suspension and resumption.mathsource fallback and a no-libffi wasm compatibility layer.-O0DWARF fixture for all three ABIs.The independent K4 diff relative to #143 is 24 files,
+581/-16, in five commits.P1 size fix
Before the runtime-boundary classification,
unicode.initacquired 24,772 resume points, including 23,480RecordPanicLocationcalls. Its lowered function reached about 4.25 MiB and Wasmtime rejected it as too large.After keeping those synchronous helpers outside the suspension set, only real suspension points remain. The largest generated function is about 746 KiB and the P1 module falls from about 6.8 MiB to 3.2 MiB in the local acceptance build.
Compatibility boundaries
The wasm libffi shim allows reflection metadata, typed method values/expressions, and reflection map operations to link and run. Raw P1 still has no compatible libffi calling backend, so dynamic
reflect.Value.Callandreflect.MakeFuncare not claimed by this PR.J32 and J64 debug fixtures pass
llvm-dwarfdump --verify. P1 is validated and executed, and its.debug_infoand.debug_linesections are asserted. Full post-link P1 range verification remains limited by existing Binaryen/WASI DWARF range rewriting.Local verification
All commands used
GOMAXPROCS=2,GOMEMLIMIT=4GiB, and-p=1where applicable.go test -p=1 ./internal/wasmresumego test -p=1 ./ssaclcaller-frame and GC-root testsgo test -p=1 ./internal/buildgo test ./internal/clite/ffi-tags=nogccross-compile/runtime regression-O0,-O2, and-O3./internal/wasmresumepassed; the broader native Ubuntu matrix is left to CI because the local amd64 image runs through Rosetta under a 7.75 GiB VM cap.Changed helper coverage is 100%;
internal/wasmresumeis 95.2% andssais 93.3%.