Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think in the end I just messed up the constant we're comparing to
__MAC_OS_X_VERSION_MIN_REQUIRED.140000should have been101400.While I was here, I refactored the
#defines a tiny bit to evaluate to plain 0s and 1s. I think this is better practice, because you aren't accidentally pasting tokens into places where they might not resolve properly.And I added an extra space of indentation because the it made nested
#ifs easier to read.Finally I had to make some fixes to the CI build - I guess Github actions has changed out the compiler on us.