Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Dec 18, 2025

Just maintenance.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch spdx-verlib2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

@amotl amotl Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setup.py can be removed soon?

@amotl amotl requested review from seut and surister December 18, 2025 21:53
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this more related to https://peps.python.org/pep-0639/? Afaik we used SPDX expressions even before. I'd suggest to update the commit message to reflect this.

readme = "README.rst"
license = { file = "LICENSE"}
license = "Apache-2.0"
license_files = ["LICENSE"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://packaging.python.org/en/latest/guides/licensing-examples-and-user-scenarios/ there is no need to explicitly define license_files or license_file?

Suggested change
license_files = ["LICENSE"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants