-
Notifications
You must be signed in to change notification settings - Fork 32
Chore: Use SPDX. Update verlib2. #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
... as suggested by warning message emitted by `python -m build`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setup.py can be removed soon?
seut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this more related to https://peps.python.org/pep-0639/? Afaik we used SPDX expressions even before. I'd suggest to update the commit message to reflect this.
| readme = "README.rst" | ||
| license = { file = "LICENSE"} | ||
| license = "Apache-2.0" | ||
| license_files = ["LICENSE"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://packaging.python.org/en/latest/guides/licensing-examples-and-user-scenarios/ there is no need to explicitly define license_files or license_file?
| license_files = ["LICENSE"] |
Just maintenance.