Types: Add method ObjectArray.as_generic#23
Merged
Conversation
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
from
f24a693 to
6092c68
Compare
This was referenced Jan 16, 2024
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
2 times, most recently
from
02164f4 to
917c901
Compare
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
from
917c901 to
ccb81a6
Compare
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
from
ccb81a6 to
a9c953e
Compare
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
2 times, most recently
from
1c2c212 to
adff60b
Compare
kneth
approved these changes
Jun 4, 2026
| self.operator = operator | ||
|
|
||
|
|
||
| # TODO: Should this be inherited from PostgreSQL's |
Contributor
Author
There was a problem hiding this comment.
AFAIK, it is needed for reverse type lookups.
amotl
force-pushed
the
amo/objectarray-asgeneric
branch
from
adff60b to
b8a21d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
AFAIK, this patch is needed for improved reverse type lookups, in this case for CrateDB's ARRAY type.
References