prepare subtree split for a standalone library (while preserving namespaces) #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #147. The files are still moved into separate folders (now one for the bundle and one for the component), but no namespace changes are needed by only adapting the autoloading paths. This way, there's no BC break as well.
But while giving these changes a try in real projects based on Symfony 2.6.9 and 2.7.1, I noticed that the translations still need to be part of the bundle (the original intention was to place them in the component), because when using a compiler pass to register the translation files in the container (as done in #147), they would be added last and users would have no chance to override the provided translations. It would be good to have a test to ensure that they actually can be overridden, but I don't see how to implement one.
As mentioned in the previous PR: The subtree split is available for testing - https://github.com/craue/CraueFormFlow - but don't rely on forward-only commits as the branch might be rewritten several times until this PR is eventually merged.
/ping @daFish