Skip to content

Conversation

@henderkes
Copy link
Collaborator

@henderkes henderkes commented Dec 1, 2025

What does this PR do?

  • Closes new libxslt version fails build #981
  • automatically updates libxml2, libwebp and go-xcaddy for new versions
  • fixes build of pdo_sqlsrv from git, rather than a release tarball
  • fixes liburing build for non-gcc on old linux header systems (rhel 8 and older)

This was what is required to build php 8.5 extensions (with 4 overridden source urls) by static-php/packages: see https://github.com/static-php/packages/blob/c5f504b532e394bd54391fa47501d7d07c6b03ee/config/templates/craft.yml.twig#L51

@crazywhalecc crazywhalecc added the mixed PR This PR contains multiple updates label Dec 4, 2025
@crazywhalecc
Copy link
Owner

crazywhalecc commented Dec 4, 2025

Speaking of which, I haven't set up any new command-line override rules for 3.0 yet. Besides the currently limited custom-url, custom-git, and custom-local options, what good methods do you think could be used to design a command-line overriding way?

The current version 3.0 (dev) allows users to register additional registry entries to override basic configs to let someone wants to override or expand functions on top of them. I don't know if it makes sense to continue expanding --custom-*, for common use.

Making another --custom={source_name}:{json} is very straightforward, but I don't think I'd even use it myself.

@henderkes
Copy link
Collaborator Author

I would say we scrap the custom url thing entirely and instead give users an option to add a second source.json?

We should chat about what features we no longer want to support and what we want to rework.

@crazywhalecc
Copy link
Owner

crazywhalecc commented Dec 4, 2025

I would say we scrap the custom url thing entirely and instead give users an option to add a second source.json?

We should chat about what features we no longer want to support and what we want to rework.

All the implementation I made has been committed to the v3-dev branch. The refactoring status is in #980 . If you have any other ideas, free to leave a message on Discord or submit a new RFC.

@crazywhalecc crazywhalecc mentioned this pull request Dec 5, 2025
6 tasks
@henderkes
Copy link
Collaborator Author

@crazywhalecc this should be merged and tagged with a new release soon. Everyone who is building from main branch or old versions will run into failures if they attempt to use libxslt.

@henderkes henderkes merged commit 07ea1e2 into main Dec 10, 2025
13 checks passed
@henderkes henderkes deleted the henderkes-patch-1 branch December 10, 2025 09:01
@henderkes
Copy link
Collaborator Author

Perfect, please tag a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mixed PR This PR contains multiple updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new libxslt version fails build

3 participants