Skip to content

fix: correct message pattern for get all oid4vc offers API#1585

Merged
sujitaw merged 1 commit into
mainfrom
fix/get_all_oid4vc_offers_api
Mar 17, 2026
Merged

fix: correct message pattern for get all oid4vc offers API#1585
sujitaw merged 1 commit into
mainfrom
fix/get_all_oid4vc_offers_api

Conversation

@sujitaw

@sujitaw sujitaw commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

What

  • corrected the message pattern for get all offers api

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated credential offer retrieval to fetch all available offers instead of a limited subset.

Signed-off-by: sujitaw <sujit.sutar@ayanworks.com>
@sujitaw
sujitaw requested a review from shitrerohit March 17, 2026 06:22
@sujitaw sujitaw self-assigned this Mar 17, 2026
@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6e3c2338-25d8-41b3-a729-dca3194fb14b

📥 Commits

Reviewing files that changed from the base of the PR and between 1673193 and cb0812f.

📒 Files selected for processing (1)
  • apps/oid4vc-issuance/src/oid4vc-issuance.service.ts

📝 Walkthrough

Walkthrough

A NATS command pattern in the oid4vc-issuance service was renamed from agent-service-oid4vc-get-credential-offers to agent-service-oid4vc-get-all-credential-offers to fetch all credential offers instead of a filtered subset.

Changes

Cohort / File(s) Summary
NATS Command Pattern Update
apps/oid4vc-issuance/src/oid4vc-issuance.service.ts
Updated NATS command pattern in both inline method and helper to use the "get-all-credential-offers" variant for comprehensive credential offer retrieval.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • feat: oid4vc issuance #1455: Introduces agent-service message patterns for fetching all credential offers, which aligns with this PR's command pattern rename.

Poem

🐰 With a hop and a bound through the NATS so swift,
All credential offers gathered—what a gift!
From filtered few to all-inclusive cheer,
The rabbit's work ensures no offers disappear! 🎫

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: correct message pattern for get all oid4vc offers API' directly and clearly describes the main change in the pull request: updating the NATS command pattern for retrieving OID4VC credential offers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/get_all_oid4vc_offers_api
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@sonarqubecloud

Copy link
Copy Markdown

@sujitaw
sujitaw requested a review from GHkrishna March 17, 2026 06:24
@sujitaw
sujitaw merged commit 8e2a5df into main Mar 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants