Skip to content
This repository was archived by the owner on Oct 23, 2021. It is now read-only.

WIP: Modularize project#53

Open
SkyLeite wants to merge 7 commits into
creesch:masterfrom
SkyLeite:master
Open

WIP: Modularize project#53
SkyLeite wants to merge 7 commits into
creesch:masterfrom
SkyLeite:master

Conversation

@SkyLeite

@SkyLeite SkyLeite commented Apr 3, 2019

Copy link
Copy Markdown

This is an initial proposal of a better structure for the project, as proposed in #51.

src/services/discord.ts - Class that interacts with the Discord client
src/services/irc.ts - Class for the IRC server. Still a lot of TODOs, listed in todo.org
util/SocketEx.ts - A wrapper that promisifies net.Socket's asynchronous methods for proper usage
util/parseMessage.ts - Message parsing stuff

I also took the liberty of using Typescript, which I believe makes the development process incredibly more comfortable, especially when messing with runtime data types.

I apologize in advance for the bad commit messages. My work is usually all over the place so I never know what to say :p

Comment thread package.json
"erlpack": "github:hammerandchisel/erlpack",
"request": "^2.81.0"
"request": "^2.81.0",
"winston": "git+https://github.com/winstonjs/winston.git"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are not including winston by version number here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the npm repository is Winston 2, which is being replaced by Winston 3 (the version in the github repository) in the near future.

@creesch

creesch commented Apr 3, 2019

Copy link
Copy Markdown
Owner

I had a quick look over and so far it looks good to me. The way you are implementing classes makes sense and should make things easier to maintain.

I don't usually use typescript in my projects but also don't have any objections to it.

I don't know if I will have time to do a proper full review in the near future (as you might have noticed by activity on the project I haven't exactly had a lot of time). I'll see if I can get some other people that use the project to chip in.

@SkyLeite SkyLeite changed the title Modularize project WIP: Modularize project Apr 3, 2019
@SkyLeite

SkyLeite commented Apr 3, 2019

Copy link
Copy Markdown
Author

There's still quite a bit to be done, so no rush :)

@Chew

Chew commented Sep 8, 2020

Copy link
Copy Markdown

Any progress on this?

@thatsprettygood

Copy link
Copy Markdown

It's dead.

@SkyLeite

Copy link
Copy Markdown
Author

Sorry folks, I don't think I'll be working on this anymore. If anyone is inclined, feel free to fork and continue the work :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants