fix: adding fix for newline after < in german gmails#46
Open
ThriceGood wants to merge 1 commit intocrisp-oss:masterfrom
Open
fix: adding fix for newline after < in german gmails#46ThriceGood wants to merge 1 commit intocrisp-oss:masterfrom
ThriceGood wants to merge 1 commit intocrisp-oss:masterfrom
Conversation
Contributor
|
Thank you for this. I will merge, but once we have other PRs to be batched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was already an addition for the English version of this problem. Where a newline is added after the < before the email in the 'from' line (I guess on long email addresses only?).
I also consolidated the two German Gmail regexes into one that handles the following formats:
Am DATE um TIME Uhr schrieb NAME <\nEMAIL>: (new line after first <)
Am DATE um TIME Uhr schrieb NAME :
Am DATE um TIME schrieb NAME:
Am DATE schrieb NAME :
I could not run the tests just to an import issue but ran a separate test for them with the following script:
Please run the original tests if you can.