Refactor of JS, no longer require jQuery#10
Open
s-thom wants to merge 4 commits intocrobi:masterfrom
s-thom:js-refactor
Open
Refactor of JS, no longer require jQuery#10s-thom wants to merge 4 commits intocrobi:masterfrom s-thom:js-refactor
s-thom wants to merge 4 commits intocrobi:masterfrom
s-thom:js-refactor
Conversation
Update to latest version of crobi's master
Remove jQuery statements, replace with equivalent "vanilla" javascript statements. The `32` in line 46 of `quickref.js` refers to the top and bottom border of `#modal-container` + top and bottom margin for its parent. It would be easily calculated, but would leave a long and possibly confusing line.
CSS rules changed in `b9080458d19d399e36a0acec17b0f8c66a5f28c5` (Remove need for jQuery) mean it will be at 100%. If the modal goes off the screen, the backdrop will not continue below that point. This can be seen on some mobile devices with the `move` movement action and the `attack` action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to quickref.js to remove the dependency on jQuery.