Fix throwing with client-supplied invalid cookie #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that a client could use invalid symbols in cookie name or value. Cro was throwing in such situation. With this fix a cookie with bad name or value would be skipped as if it didn't exist.
FCO
pushed a commit
to FCO/cro-http
that referenced
this pull request
Oct 2, 2025
FCO
pushed a commit
to FCO/cro-http
that referenced
this pull request
Oct 2, 2025
japhb
added a commit
that referenced
this pull request
Oct 2, 2025
Fix throwing with client-supplied invalid cookie (copy of #126 vrurg++)
Contributor
|
Closed in favor of #210 which is an updated copy of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that a client could use invalid symbols in cookie name or
value. Cro was throwing in such situation. With this fix a cookie with
bad name or value would be skipped as if it didn't exist.