Adding named endpoints #207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It adds `Str :$name` to the `http` functions (`get`, `put`, `post`, etc) and a `Str $.name` to `RouteHandler` class. On `Cro::HTTP::Router` it adds `Handler %.named-routes` and `Handler %.generated-named-routes` to store the handlers indexed by name (passed or generated). It also adds the methods `generate-name` to be able to generate a name if one wasnt provided, and `path-template` and `path` to, having the `Handler` (you can gat using the new exported sub `endpoint(Str $name)`) be able to get it's path-template and it's path (receiving named parameters to populate the vars). It also alters `redirect` to, if the location passed is a name of an endpoint, uses its path (it also accepts `:%params` to be used to populate the path) as location to be redirected (unless also passed `:!named-endpoint`). And finally it also exports a sub called `list-routes` that returns a string listing all routes and their names.
Contributor
|
Closing in favor of #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds
Str :$nameto thehttpfunctions (get,put,post, etc) and aStr $.nametoRouteHandlerclass.On
Cro::HTTP::Routerit addsHandler %.named-routesandHandler %.generated-named-routesto store the handlers indexed by name (passed or generated).It also adds the methods
generate-nameto be able to generate a name if one wasnt provided, andpath-templateandpathto, having theHandler(you can gat using the new exported subendpoint(Str $name)) be able to get it's path-template and it's path (receiving named parameters to populate the vars).It also alters
redirectto, if the location passed is a name of an endpoint, uses its path (it also accepts:%paramsto be used to populate the path) as location to be redirected (unless also passed:!named-endpoint).And finally it also exports a sub called
list-routesthat returns a string listing all routes and their names.