Skip to content

fix: two HAL stub gaps blocking firmware builds against the simulator #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfoulad wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix: two HAL stub gaps blocking firmware builds against the simulator #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892d281
fix: add forceCleanBaseOnHalf param to displayBuffer
sfoulad Aug 7, 2026
a78a83a
fix: add HTTP_METHOD_DELETE to esp_http_client stub
sfoulad Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/HalDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,10 @@ bool HalDisplay::toggleInverted() {

bool HalDisplay::isInverted() const { return inverted; }

void HalDisplay::displayBuffer(RefreshMode mode, bool turnOffScreen) {
void HalDisplay::displayBuffer(RefreshMode mode, bool turnOffScreen,
bool /*forceCleanBaseOnHalf*/) {
// The simulator has no e-ink half-refresh base to keep clean, so the
// base-clearing guarantee this flag requests on-device is a no-op here.
refreshDisplay(mode, turnOffScreen);
}

Expand Down
3 changes: 2 additions & 1 deletion src/HalDisplay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class HalDisplay {
bool isInverted() const;

void displayBuffer(RefreshMode mode = RefreshMode::FAST_REFRESH,
bool turnOffScreen = false);
bool turnOffScreen = false,
bool forceCleanBaseOnHalf = true);
void displayBufferAsync(RefreshMode mode = RefreshMode::FAST_REFRESH);
void waitRefreshComplete();
bool supportsAsyncRefresh() const;
Expand Down
3 changes: 3 additions & 0 deletions src/esp_http_client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ enum esp_http_client_method_t {
HTTP_METHOD_GET,
HTTP_METHOD_POST,
HTTP_METHOD_PUT,
HTTP_METHOD_DELETE,
};

enum esp_http_client_auth_type_t {
Expand Down Expand Up @@ -72,6 +73,8 @@ inline const char *methodName(esp_http_client_method_t method) {
return "POST";
case HTTP_METHOD_PUT:
return "PUT";
case HTTP_METHOD_DELETE:
return "DELETE";
case HTTP_METHOD_GET:
default:
return "GET";
Expand Down