Only skip building with WK2 editor #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-hellings
force-pushed
the
editor/webkit2-only-skip
branch
from
0d28a46 to
2522580
Compare
WebKit1 does not know how to handle `application/xhtml+xml` in our Windows build, meaning the editor is pre-populated with lots of garbage. This garbage becomes actual HTML header that is properly parsed when declared as `text/html` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores editor functionality for systems using WebKit1 API (most notably Windows builds).
Maintains the not-supported error message when looking at WebKit2 editor builds