-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Add support for new report schemas #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andrii-bodnar I have made the files based on what I have understood please take a look and provide me with comments to improve this pr. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 94.10% 94.12% +0.02%
- Complexity 883 884 +1
============================================
Files 199 199
Lines 3082 3090 +8
Branches 61 61
============================================
+ Hits 2900 2908 +8
Misses 153 153
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @Suvrat1629. Please address the comments below. All new report schemas need to be carefully reviewed.
src/main/java/com/crowdin/client/reports/model/EditorIssuesGenerateReportRequest.java
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/GroupQaCheckIssuesGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/GroupTaskUsageGenerateReportRequest.java
Show resolved
Hide resolved
...ain/java/com/crowdin/client/reports/model/GroupTranslationActivityGenerateReportRequest.java
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/ProjectMembersGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/QaCheckIssuesGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/SavingActivityGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/SourceContentUpdatesGenerateReportRequest.java
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/TranslationActivityGenerateReportRequest.java
Show resolved
Hide resolved
|
@andrii-bodnar Sorry for the confusion I have pushed changes to the pr. Please take a look. |
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please kindly check all the Schemas for the report types.
src/main/java/com/crowdin/client/reports/model/GroupTaskUsageGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/GroupTaskUsageGenerateReportRequest.java
Show resolved
Hide resolved
...ain/java/com/crowdin/client/reports/model/GroupTranslationActivityGenerateReportRequest.java
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/ProjectMembersGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/QaCheckIssuesGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/SavingActivityGenerateReportRequest.java
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/SourceContentUpdatesGenerateReportRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/crowdin/client/reports/model/TranslationActivityGenerateReportRequest.java
Show resolved
Hide resolved
|
@andrii-bodnar I have made changes and also changed some schemas to that I thought I was missing fields also could you tell me if I should keep |
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Suvrat1629 looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Description
Adds support for 9 new report schemas introduced in the Crowdin API, addressing issue #322.
New Report Schemas Added
Standard Reports:
source-content-updates- Tracks changes to source content over timeproject-members- Lists project members with roles and access levelseditor-issues- Reports issues encountered in the Crowdin editorqa-check-issues- Details QA check failures per string/languagesaving-activity- Logs saving actions in the editor (translations, approvals)translation-activity- Comprehensive translation activity and progress trackingEnterprise-Only Reports:
group-task-usage- Task usage statistics across group projectsgroup-qa-check-issues- Aggregated QA issues across group projectsgroup-translation-activity- Aggregated translation activity across group projectsCloses #322