Skip to content

Conversation

@vinayakkamatcodes
Copy link

This PR adds the optional acceptSourceChanges parameter to the MergeBranchRequest TypedDict for the string-based API. Resolves #217

@andrii-bodnar andrii-bodnar requested a review from Copilot October 30, 2025 15:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new field acceptSourceChanges to the MergeBranchRequest TypedDict class, expanding the merge branch request parameters to support accepting source changes during branch merging operations.

  • Added acceptSourceChanges boolean field to MergeBranchRequest typed dictionary

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

deleteAfterMerge: Optional[bool]
sourceBranchId: int
dryRun: Optional[bool]
acceptSourceChanges: bool
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptSourceChanges field should be typed as Optional[bool] to maintain consistency with other optional fields in the MergeBranchRequest class (deleteAfterMerge and dryRun). Unless this is a required field, making it optional would provide a more flexible API design.

Suggested change
acceptSourceChanges: bool
acceptSourceChanges: Optional[bool]

Copilot uses AI. Check for mistakes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakkamatcodes please address the comment above so I can merge the PR

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (b6d9323) to head (afba9fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +0.01%     
==========================================
  Files         178      178              
  Lines        8216     8217       +1     
  Branches      185      185              
==========================================
+ Hits         8162     8163       +1     
  Misses         39       39              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrii-bodnar andrii-bodnar changed the title Feat: Add support for acceptSourceChanges in string-based MergeBranch API feat: Add support for acceptSourceChanges in string-based MergeBranch API Nov 12, 2025
@andrii-bodnar andrii-bodnar marked this pull request as draft November 12, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for acceptSourceChanges parameter in Merge Branch API

3 participants