Skip to content

Conversation

@pjcodes404
Copy link
Contributor

This PR adds full support for attachments in string comments, following the latest Crowdin API updates.

Implemented Changes

  • Added support for the attachments parameter in add_string_comment

  • Added new delete_string_comment_attachment endpoint

  • Updated the request payload to include attachments when creating comments

  • Added and updated unit tests to verify:

    • attachments are included when adding comments
    • the correct delete endpoint is called
    • existing comment functionality remains unaffected

Verification

  • Ran full test suite
  • 902 tests passed, 0 failures
  • Test coverage: 99.26% (meets required 95%)
  • All new functionality validated through dedicated unit tests

Notes

  • API behavior fully matches the updated Crowdin documentation
  • No breaking changes introduced

@pjcodes404 pjcodes404 marked this pull request as draft December 1, 2025 11:29
@pjcodes404 pjcodes404 marked this pull request as ready for review December 1, 2025 11:30
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (b6d9323) to head (ae61c6e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +0.01%     
==========================================
  Files         178      178              
  Lines        8216     8225       +9     
  Branches      185      185              
==========================================
+ Hits         8162     8171       +9     
  Misses         39       39              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrii-bodnar andrii-bodnar linked an issue Dec 1, 2025 that may be closed by this pull request
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjcodes404 thank you!

@andrii-bodnar andrii-bodnar merged commit 72ad81f into crowdin:main Dec 1, 2025
6 checks passed
@pjcodes404 pjcodes404 deleted the feature/string-comment-attachments branch December 1, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for String Comment Attachments

3 participants