-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add systemctl reload support for host configuration #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
399815f
feat: add systemctl reload support for host configuration
LaurenceJJones ea28c41
refactor: remove unused context from host manager
LaurenceJJones 1479273
refactor: extract component initialization to Host.InitComponents()
LaurenceJJones a334eef
refactor: simplify replaceHosts since sessions are managed globally
LaurenceJJones 0077ec2
fix: resolve race condition and eliminate code duplication in host ma…
LaurenceJJones 3c3c3d5
fix: resolve golangci-lint control flag warning
LaurenceJJones d073b0d
refactor: collect errors instead of using control flags
LaurenceJJones 3cb8328
refactor: simplify error messages to avoid redundancy in logs
LaurenceJJones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing validation that
HostManager.Reload()is not called beforeSetHosts(). TheReload()method relies onh.hostsDirbeing set, but if SIGHUP is received beforeSetHosts()is called (lines 213-216),h.hostsDirwill be empty and the reload will silently skip loading from the directory.Consider either:
Reload()to ensure initialization has completedSetHosts()completes