fix(prometheus): add graceful shutdown for server #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Prometheus server to match pprof pattern: - Use dedicated http.ServeMux instead of default mux - Manage server lifecycle with errgroup - Add graceful shutdown handler with 5s timeout - Proper error propagation instead of fire-and-forget goroutine This ensures the Prometheus server shuts down cleanly on SIGTERM/SIGINT and errors are properly tracked by the errgroup.
LaurenceJJones
changed the title
Copilot finished reviewing on behalf of
LaurenceJJones
December 3, 2025 16:23
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Prometheus metrics server to match the established pprof server pattern, ensuring consistent server lifecycle management across the codebase. The change replaces a fire-and-forget goroutine with proper errgroup-based lifecycle management and graceful shutdown handling.
Key Changes
- Replaced default HTTP mux with dedicated ServeMux to avoid conflicts
- Integrated server lifecycle with errgroup for proper error propagation and coordinated shutdown
- Added graceful shutdown handler that responds to SIGTERM/SIGINT with 5-second timeout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Prometheus server to match pprof pattern:
This ensures the Prometheus server shuts down cleanly on SIGTERM/SIGINT and errors are properly tracked by the errgroup.