split up sample() to allow backwards pass#4
Open
dribnet wants to merge 8 commits intocrowsonkb:masterfrom
Open
split up sample() to allow backwards pass#4dribnet wants to merge 8 commits intocrowsonkb:masterfrom
dribnet wants to merge 8 commits intocrowsonkb:masterfrom
Conversation
Author
|
(this branch has been caught up, but the CLIP submodule dependency was also removed in f96d121. I can further clean this up by reverting this commit and flatten this history if you are interested in incorporating these changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor takes the existing sample() call and splits it into subroutines disabling
@torch.no_grad()to enable optimisation ofx. Could be further cleaned up, but this version is working well currently with downstream code.