Destroy the Network graph on component unload#132
Open
daliborfilus wants to merge 1 commit intocrubier:masterfrom
Open
Destroy the Network graph on component unload#132daliborfilus wants to merge 1 commit intocrubier:masterfrom
daliborfilus wants to merge 1 commit intocrubier:masterfrom
Conversation
Author
|
I can confirm that by adding this, the graph re-renders again and again successfully without performance loss. |
|
+1, this is great |
ObaidAshiq
reviewed
Jun 20, 2024
ObaidAshiq
left a comment
ObaidAshiq
left a comment
There was a problem hiding this comment.
Seems like for above 300 nodes its a problem, but for smaller amount of nodes, it isn't
But its good to have this feature for certain case
Really liked it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #131