Skip to content

Conversation

@darnfish
Copy link
Contributor

This PR extracts ControlBar to a separate component and places it in player. This also includes support for the updated design which requires a @cryb/borealis update

darnfish added 2 commits May 30, 2020 01:41
Buttons that require REST-ful actions already have the rainbow loading animation
@darnfish darnfish added the enhancement New feature or request label May 30, 2020
@darnfish darnfish requested a review from Soliel May 30, 2020 00:44
@darnfish darnfish self-assigned this May 30, 2020
@jeda jeda self-requested a review May 30, 2020 00:47
...script
]
},
loadingIndicator: '~/components/Loading/index.html',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get to dislike that loading indicator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put reasoning in the commit description

Screenshot 2020-05-30 at 01 49 07

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the page that's shown before the whole app loads, so it should be kept.

@darnfish
Copy link
Contributor Author

Opened a PR over at Borealis: crybapp/borealis#3

@jeda
Copy link
Member

jeda commented May 30, 2020

While this seems nice, and I was planning to move the control bar to a separate component that's included in Player, I am not sure of the way it is being done because I feel it can cause problems in controlling the VM in case you need to click things on the bottom, hence me wanting to avoid putting the controls over the video all this time. I'm not sure, though, but I feel the rest should have a say on this one, too.

@darnfish
Copy link
Contributor Author

darnfish commented May 30, 2020

The control bar is hidden if you're the controlling the VM; I could work on something that moves the control bar under the player if you're currently controlling the VM instead of just removing it outright?

@jeda
Copy link
Member

jeda commented May 30, 2020

That could possibly work and fit better.

@darnfish
Copy link
Contributor Author

Here's a small mockup: the user can bring their cursor to the right side of the preview area and it'll bring up the control bar. As most users are using Cryb on their desktop with wider screens this hit-region should hopefully be on the black bars. Only issue is it isn't very intuitive to figure out, might be worth adding a tip/alert that it's possible. Or I could add a small FAB to the bottom right on the player to do the same thing.

screencast 2020-05-30 02-16-00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants