feat: update system-time rule to not trigger on time.Now().Round(0).UTC()#8
Open
julienrbrt wants to merge 1 commit intocrypto-com:mainfrom
Open
feat: update system-time rule to not trigger on time.Now().Round(0).UTC()#8julienrbrt wants to merge 1 commit intocrypto-com:mainfrom
time.Now().Round(0).UTC()#8julienrbrt wants to merge 1 commit intocrypto-com:mainfrom
Conversation
20 tasks
Contributor
|
Hello @julienrbrt , thank you for your PR and sorry the late reply. I read your Cosmos SDK reference and understand the use of However, I believe the existence of this rule is for a wider context that inside any state transition there shouldn't be use of As a result, I don't think we should loosen this rule or suggest to use UTC time. Happy to discuss further here. |
Author
|
That is definitely true. Do you think there is a way to tweak this rule better then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: cosmos/cosmos-sdk#18239 (comment)
I am not too familiar with CodeQL expression, so I have used GitHub Copilot to help me.