Fix the order of active/owner keys when calling register#2
Open
svk31 wants to merge 1 commit intocryptonomex:masterfrom
Open
Fix the order of active/owner keys when calling register#2svk31 wants to merge 1 commit intocryptonomex:masterfrom
svk31 wants to merge 1 commit intocryptonomex:masterfrom
Conversation
Da99er
approved these changes
Mar 28, 2017
Author
|
@valzav Do you have write access here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implementing role based key generation based on passwords I noticed the faucet was flipping the active/owner keys. This fixes that issue. Thanks to @xeroc for helping spot it.