Merged
Conversation
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 60. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ronjakrg
requested changes
Jan 24, 2025
ronjakrg
requested changes
Feb 1, 2025
Collaborator
ronjakrg
left a comment
There was a problem hiding this comment.
Ich habe mal etwas ausführlicher drüber geschaut. Sehr viele nice Ideen und die Benutzung ist soo viel besser als vorher! Habe ein paar kleinere Anmerkungen gemacht :)
sarahvgls
requested changes
Feb 5, 2025
Collaborator
sarahvgls
left a comment
There was a problem hiding this comment.
Ein paar Kommentare noch von meiner Seite, recht wenig zum Frontend hier, da das ja dann vermutlich sowieso noch mal verändert werden muss
Collaborator
Author
|
Vielen Dank für das ganze Feedback, ich habe viel davon umgesetzt und implementiert :) |
sarahvgls
approved these changes
Feb 8, 2025
Collaborator
|
Danke für die Änderungen! Sieht voll gut aus so!! |
ronjakrg
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #489
Enable a fast datatable-page via server-side paging, searching and sorting. Also fix small bugs
Changes
big changes:
datatables-control.js
tables.html
mid changes:
views.py
views_helper.py
small changes:
run.py
steps.py
Testing
PR checklist
Development
Mergeability
blackCode review