Skip to content

switch to @zkochan/cmd-shim #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cspotcode wants to merge 1 commit into
base: master
Choose a base branch
from
Open

switch to @zkochan/cmd-shim #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@types/unzipper": "^0.8.4",
"@types/webpack": "^4.4.9",
"@types/which": "^1.3.1",
"cmd-shim": "^2.0.2",
"@zkochan/cmd-shim": "^5.0.0",
"cross-spawn": "^6.0.5",
"execa": "^4.0.3",
"get-stream": "^3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import * as tar from 'tar';
import { Readable } from 'stream';
import { platform } from 'os';
import * as unzipper from 'unzipper';
import * as cmdShim from 'cmd-shim';
import * as cmdShim from '@zkochan/cmd-shim';
import { promisify } from 'util';
import { Extension } from './version-utils';
import * as stream from 'stream';
Expand Down Expand Up @@ -263,7 +263,7 @@ export async function createSymlinkTo(args: {
// Windows platforms: use cmd-shim
if(process.platform === 'win32') {
log(`Creating .cmd shim from ${ linkPath } to ${ targetPath } (via ${ intermediateLinkPath })...`);
await promisify(cmdShim)(targetPath, intermediateLinkPath.replace(/\.cmd$/, ''));
await promisify(cmdShim)(targetPath, intermediateLinkPath.replace(/\.cmd$/, ''), {});
}
// Non-windows platforms: use a symlink to a symlink
// Intermediate symlink is necessary because npm refuses to delete .bin/<symlink> unless it points to *within* the module's directory
Expand Down