Skip to content

Remove auto-approval step before merging PR for develop updates #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
The0mikkel merged 3 commits into from
Nov 16, 2025
Merged

Remove auto-approval step before merging PR for develop updates #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fcd66a
CI: Update develop to match main (#15)
The0mikkel Nov 16, 2025
e50a168
fix(develop-update): remove auto-approval step before merging PR for …
The0mikkel Nov 16, 2025
8cf4db0
Merge branch 'develop' of https://github.com/ctfpilot/ci into develop
The0mikkel Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/develop-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@ jobs:
- name: "Auto-merge Pull Request"
if: (steps.check_merge_source.outputs.latest_from_develop == 'true' || steps.check_merge_source.outputs.latest_from_develop == 'not_merge') && inputs.auto_merge != false
run: |
# Approve PR
gh pr review "${{ steps.create_pr.outputs.URL }}" --approve --body "Auto-approved by CI for merging develop update."

# Merge PR
gh pr merge "${{ steps.create_pr.outputs.URL }}" -t "chore(ci): Auto update develop to match main [skip ci]" -b "This was done automatically by the CI pipeline" --merge --auto
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the auto-approval step may cause issues if the develop branch has branch protection rules requiring PR approvals. The gh pr merge --auto command will enable auto-merge but will wait for all required approvals and status checks before completing the merge. Without the approval step, the PR will remain in a pending state indefinitely if approvals are required, defeating the purpose of auto-merge.

Consider one of the following approaches:

  1. Ensure the develop branch does not require approvals for this automated workflow (e.g., by allowing the GitHub Actions bot to bypass approval requirements)
  2. Keep the approval step but use a different token or app with appropriate permissions
  3. Document that branch protection rules for develop should not require approvals for this workflow to function correctly

Copilot uses AI. Check for mistakes.
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading