Skip to content

Remove quotes from allowlist in CLA Assistant workflow#3

Merged
The0mikkel merged 1 commit intomainfrom
develop
Nov 16, 2025
Merged

Remove quotes from allowlist in CLA Assistant workflow#3
The0mikkel merged 1 commit intomainfrom
develop

Conversation

@The0mikkel
Copy link
Member

No description provided.

@The0mikkel The0mikkel self-assigned this Nov 16, 2025
Copilot AI review requested due to automatic review settings November 16, 2025 00:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes quotes from the allowlist parameter value in the CLA Assistant workflow configuration. While this change is technically valid YAML syntax and will function correctly, it introduces a style inconsistency with other string parameters in the same workflow file.

Key Changes:

  • Modified the allowlist parameter from quoted to unquoted format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# branch should not be protected
branch: "main"
allowlist: "semantic-release-bot,semantic-release[bot]"
allowlist: semantic-release-bot,semantic-release[bot]
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Removing quotes from the allowlist parameter creates inconsistency with other string parameters in this workflow file. Other string parameters like branch: "main", remote-organization-name: "ctfpilot", and remote-repository-name: "cla" all use quotes. For consistency and maintainability, consider keeping the quotes around the allowlist value.

Suggested change
allowlist: semantic-release-bot,semantic-release[bot]
allowlist: "semantic-release-bot,semantic-release[bot]"

Copilot uses AI. Check for mistakes.
@The0mikkel The0mikkel merged commit dfd8459 into main Nov 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant