Skip to content

Conversation

@The0mikkel
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings November 16, 2025 15:08
@The0mikkel The0mikkel self-assigned this Nov 16, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates from using an external reusable workflow (the0mikkel/ci/.github/workflows/semver-release-standalone.yml@v1.4.1) to a local implementation of semantic-release directly within the repository's workflow file. This gives the repository more control over the release process and removes the external dependency.

Key Changes:

  • Replaced reusable workflow call with inline semantic-release implementation
  • Added semantic-release dependency installation and configuration steps
  • Implemented default configuration file creation with conventional commits support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

npx semantic-release 2>&1 | tee semantic-release.log
status=${PIPESTATUS[0]}
exit $status
- name: Archive release log
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantic-release log artifact upload should be conditional to handle cases where the Release step fails before creating the log file. Add if: always() to ensure the artifact upload runs even if previous steps fail:

- name: Archive release log
  if: always()
  uses: actions/upload-artifact@v5
Suggested change
- name: Archive release log
- name: Archive release log
if: always()

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@The0mikkel The0mikkel merged commit 8c335b0 into main Nov 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant