Skip to content

fix: correct err check#838

Merged
adityachoudhari26 merged 1 commit intomainfrom
fix-broken-test
Mar 6, 2026
Merged

fix: correct err check#838
adityachoudhari26 merged 1 commit intomainfrom
fix-broken-test

Conversation

@adityachoudhari26
Copy link
Member

@adityachoudhari26 adityachoudhari26 commented Mar 6, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in the release management system to ensure consistent behavior during exceptional conditions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 60ed2997-cf5c-4e1f-8296-962309bc4809

📥 Commits

Reviewing files that changed from the base of the PR and between 7bca65e and 92a3f40.

📒 Files selected for processing (2)
  • apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/deploymentwindow/getters.go
  • apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/gradualrollout/getters.go

📝 Walkthrough

Walkthrough

Modified HasCurrentRelease methods in two release manager modules to suppress errors, returning (false, nil) on error and (true, nil) on success instead of propagating the underlying error.

Changes

Cohort / File(s) Summary
Error Handling Updates in Release Manager Getters
apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/deploymentwindow/getters.go, apps/workspace-engine/pkg/workspace/releasemanager/policy/evaluator/gradualrollout/getters.go
Modified HasCurrentRelease methods to suppress errors from GetCurrentRelease, returning (false, nil) on error and (true, nil) on success instead of propagating the error value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Hop! The errors fade away,
Silent now, no more to say,
getters return with peaceful grace,
(true, nil) lights up the place! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to fixing an error check, which aligns with the changes that modify error handling behavior in two getter functions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-broken-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityachoudhari26 adityachoudhari26 merged commit 98da344 into main Mar 6, 2026
7 of 9 checks passed
@adityachoudhari26 adityachoudhari26 deleted the fix-broken-test branch March 6, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant