Convert to no_std#152
Closed
c410-f3r wants to merge 1 commit into
Closed
Conversation
c410-f3r
commented
Mar 5, 2026
| }; | ||
| (@_inner $feature:tt) => {{ | ||
| #[cfg(feature = "std")] | ||
| { crate::low::x86_64::cpu::test_toggle($feature, std::is_x86_feature_detected!($feature)) } |
Author
There was a problem hiding this comment.
Curly braces because of stmt_expr_attributes
| #[cfg(feature = "std")] | ||
| { crate::low::x86_64::cpu::test_toggle($feature, std::is_x86_feature_detected!($feature)) } | ||
| #[cfg(not(feature = "std"))] | ||
| { crate::low::x86_64::cpu::test_toggle("", false) } |
Author
There was a problem hiding this comment.
test_toggle is still called to avoid it being labeled as dead code
|
|
||
| // assorted intrinsic code | ||
| assert!( | ||
| is_x86_feature_detected!("avx"), |
| Ok(out) | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
Author
There was a problem hiding this comment.
Only called in tests, #[allow(dead_code)] is not necessary
|
|
||
| [dev-dependencies] | ||
| aws-lc-rs = { version = "1.13", default-features = false, features = ["alloc", "prebuilt-nasm", "non-fips"] } | ||
| graviola = { features = ["std"], path = "." } |
Author
There was a problem hiding this comment.
IFAICT, that is the only way to enable std in tests
| )] | ||
| #![no_std] | ||
|
|
||
| extern crate alloc; |
Author
There was a problem hiding this comment.
alloc usage by default because of RSA
|
Is there a reason this is closed? I'm also interested in this - are you still able to work on this, or should someone else take this over in a new PR? |
Author
|
Closed due to the lack of feedback. Another example is #110. Feel free to copy any associated code to open another related PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the things that
#![no_std]implies is that the prelude is no longer available, thus thestd::prefixes.