Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
========================================
Coverage 99.78% 99.78%
========================================
Files 216 217 +1
Lines 56505 56621 +116
Branches 230 234 +4
========================================
+ Hits 56382 56499 +117
+ Misses 92 91 -1
Partials 31 31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
brian-pane
reviewed
Jul 6, 2026
| @@ -0,0 +1,207 @@ | |||
| // Written for Graviola by Joe Birr-Pixton, 2025. | |||
Contributor
There was a problem hiding this comment.
Should the 2025 here be 2026?
brian-pane
reviewed
Jul 6, 2026
| } | ||
|
|
||
| let (whole_blocks, remainder) = { | ||
| let whole_len = bytes.len() - (bytes.len() & (Self::BLOCK_SZ - 1)); |
Contributor
There was a problem hiding this comment.
I checked out of curiosity, and rustc does this optimization (replacing x % BLOCK_SZ with x & (BLOCK_SZ - 1) when BLOCK_SZ is a power of two) automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #205