feat(cubesql): Support parsing IANA timezones#11140
Conversation
|
Claude finished @MazterQyou's task in 31s —— View job Code ReviewVerdict: LGTM — small, focused dependency bump with good test coverage. 0 high, 0 medium, 1 low. Review details
SummaryThis PR bumps FindingsCode Quality / Testing (low) — The test covers the happy path (a January timestamp → UTC-8). Consider also adding coverage for:
These aren't blockers — the single test demonstrates the parsing works — but DST handling is a common source of subtle timezone bugs and worth pinning down. Security / PerformanceNo concerns. Pure dependency bump + test addition; no new attack surface, no hot-path changes. DocsNo user-facing surface changed (the SQL syntax was already accepted; only the value semantics for IANA names are now correct), so no docs update is required. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11140 +/- ##
==========================================
- Coverage 83.63% 79.12% -4.51%
==========================================
Files 256 473 +217
Lines 79019 96538 +17519
Branches 0 3558 +3558
==========================================
+ Hits 66085 76387 +10302
- Misses 12934 19633 +6699
- Partials 0 518 +518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2d517d8 to
74feab7
Compare
|
Claude finished @MazterQyou's task in 39s —— View job Code ReviewVerdict: LGTM — dependency bump + targeted test. 0 high, 0 medium, 1 low. Review detailsSummaryThis PR bumps A new test FindingsTesting (low) — The single test covers a fixed-offset January date. Worth considering (not blockers):
Security / PerformanceNo concerns — dependency bump + test only; no hot-path or attack-surface changes. DocsThe accepted SQL syntax is unchanged (only the value semantics for IANA names are now correct), so no docs update needed. NitPR description mentions rev |
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
74feab7 to
4943021
Compare
|
Claude finished @MazterQyou's task in 33s —— View job Code ReviewVerdict: LGTM — dependency bump + targeted test. 0 high, 0 medium, 1 low. Review details
SummaryThis sync updates The added test FindingsTesting (low) — The single test covers a fixed-offset January date. Worth considering (not blockers):
Security / PerformanceNo concerns — dependency bump + test only; no hot-path or attack-surface changes. DocsThe accepted SQL syntax is unchanged (only the value semantics for IANA names are now correct), so no docs update needed. NitPR description says rev • Branch: |
Check List
Description of Changes Made
This PR bumps cube-js/arrow-datafusion@1a849d7, adding support for parsing IANA timezones. Related test is included.