Skip to content

Add return_async_id check to return id or members list#1351

Merged
MariusWirtz merged 3 commits intocubewise-code:masterfrom
macsir:master
Feb 18, 2026
Merged

Add return_async_id check to return id or members list#1351
MariusWirtz merged 3 commits intocubewise-code:masterfrom
macsir:master

Conversation

@macsir
Copy link
Contributor

@macsir macsir commented Feb 18, 2026

This is a minor change to bring consistency on fetching async id when specified for dimension MDX query function.

@MariusWirtz
Copy link
Collaborator

Looks good. Thank you @macsir

Please a couple of test cases similar to the ones here

def test_execute_with_return_return_async_id(self):

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the return_async_id parameter to the execute_set_mdx method in ElementService, bringing it in line with similar methods in ProcessService and other service classes.

Changes:

  • Added conditional logic to check for return_async_id parameter in kwargs
  • When return_async_id=True, the method returns the async response directly instead of parsing the JSON response
  • When return_async_id=False (default), the method continues with the original behavior of parsing and returning the members list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@macsir
Copy link
Contributor Author

macsir commented Feb 18, 2026

Hey @MariusWirtz, please take a look again. Thanks.

@MariusWirtz MariusWirtz merged commit 58e49d4 into cubewise-code:master Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments