Add return_async_id check to return id or members list#1351
Merged
MariusWirtz merged 3 commits intocubewise-code:masterfrom Feb 18, 2026
Merged
Add return_async_id check to return id or members list#1351MariusWirtz merged 3 commits intocubewise-code:masterfrom
MariusWirtz merged 3 commits intocubewise-code:masterfrom
Conversation
Collaborator
|
Looks good. Thank you @macsir Please a couple of test cases similar to the ones here tm1py/Tests/ProcessService_test.py Line 209 in a499084 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the return_async_id parameter to the execute_set_mdx method in ElementService, bringing it in line with similar methods in ProcessService and other service classes.
Changes:
- Added conditional logic to check for
return_async_idparameter in kwargs - When
return_async_id=True, the method returns the async response directly instead of parsing the JSON response - When
return_async_id=False(default), the method continues with the original behavior of parsing and returning the members list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hey @MariusWirtz, please take a look again. Thanks. |
MariusWirtz
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change to bring consistency on fetching async id when specified for dimension MDX query function.