Modernize and Update Skeleton Project#1
Open
msievenpiper wants to merge 5 commits intocubex:masterfrom
Open
Conversation
bajb
reviewed
Feb 12, 2026
Comment on lines
+35
to
+36
| $cubex->getConsole()->add($cubex->resolve(CreateTable::class)); | ||
| $cubex->getConsole()->add($cubex->resolve(GenerateContent::class)); |
Author
There was a problem hiding this comment.
To showcase the two different ways to add in console commands, this way you want include more details and it actually runs the ->configure() method to allow for better detailing of options etc.
I've also included the commands in the config as per usual, where you can see the command aliasing etc.
Depends on the preference but I have a preference to adding them directly into console so when you run ./cubex list you get a more consistent output.
bajb
reviewed
Feb 12, 2026
|
|
||
| use Cubex\Cubex; | ||
| use Project\Context\SkeletonContext; | ||
| use Project\DefaultApplication; |
Author
There was a problem hiding this comment.
Without these changes the changes I made to the Cli application won't be shown correctly as cubex will start without the additional loading/config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Skeleton Project is quite old and in need of some TLC, this is my first attempt at making a more modern version with support for Phpstan and a more robust readme.
@bajb This will be a better start I think than the current version.
Later additions I want to add are: