M3 config still set a removed flag (REQUIRE_TOOL_CALL_BEFORE_FINAL) instead of enabling CUGA_LITE_NL_AUTO_CONTINUE#117
Open
haroldship wants to merge 4 commits into
Open
M3 config still set a removed flag (REQUIRE_TOOL_CALL_BEFORE_FINAL) instead of enabling CUGA_LITE_NL_AUTO_CONTINUE#117haroldship wants to merge 4 commits into
haroldship wants to merge 4 commits into
Conversation
Remove the dead cuga-agent counter flag from m3.env and enable CUGA_LITE_NL_AUTO_CONTINUE (aligned with AppWorld). Add issue451 A/B eval-keys for planning-stall and ungrounded-final probes (#116).
📝 WalkthroughWalkthroughM3 replaces the removed tool-call finalization setting with natural-language auto-continue and adds three evaluation key lists covering planning-text smoke, confirmation, and consistency probes. ChangesM3 NL auto-continue configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace the old find-tools-only candidates with the four zero-tool IDs from the m3_task_2 baseline so the B probe matches current failure modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imagine you have a rule "always double-check before finishing," but someone removes that rule from the app — except your test script still flips the switch for the rule that no longer exists. That's what was happening here.
M3's config was still setting
REQUIRE_TOOL_CALL_BEFORE_FINAL=true, but that flag was removed from cuga-agent a while back (#416 / #451). So M3 wasn't actually testing anything real — it was flipping a switch that wasn't wired to anything, and the real mechanism that catches an agent stalling on planning-text instead of calling a tool was never being exercised.What this PR does
CUGA_LITE_NL_AUTO_CONTINUE=true. This is the live feature that nudges the agent to keep going instead of quitting early when it outputs planning text instead of a tool call (this already matches how AppWorld is configured).issue451_a_n1,issue451_a_n3,issue451_b_probe5— probing both the planning-stall case and the "answers without grounding" case.Fixes #116. Related: cuga-agent#451.
Testing
issue451_b_probe5loads and runs correctly under--eval-keywith NL auto-continue on. Full retest ofissue451_a_n1/n3is a follow-up once the agent's planning fast-path lands.