Introduce sub-(sub-)rounds to tournament round counting and PGN#702
Open
alwey wants to merge 1 commit intocutechess:masterfrom
Open
Introduce sub-(sub-)rounds to tournament round counting and PGN#702alwey wants to merge 1 commit intocutechess:masterfrom
alwey wants to merge 1 commit intocutechess:masterfrom
Conversation
and PGN output. Resolves cutechess#249 Use subround counting for round-robin tournaments. This fixes the round repetition policy where the PGN round does not correspond to a round specified by the -rounds option. Now the PGN round tag is constant for the whole cycle of sub-rounds. Resolves cutechess#641 To accomplish a more fine-grained control of openings two new policy options are introduced to OpeningPolicy: 1. SubRoundPolicy which shifts openings for a new sub-round. 2. KeepPolicy which always keeps the same opening. Thus there a policies to shift or not shift openings for the levels of a tournament (game, encounter, sub-round, round, tournament). For pyramid tournaments the function of the round counter is now distributed between round and sub-round counter. In knockout tournaments the sub-round is constant for a pair, the sub-sub-round counts the games of a pair. In gauntlet tournaments the sub-round counter tracks the gauntlet (seeded) players, the sub-sub-round counter individual games. The "round" field was changed from int to QString in PgnGame.
|
Hi! This is Erik, CEO of Chess.com. We are currently hiring for two important roles on our engineering team: Chess Explanation Engineer, and Engineering Team Lead - Analysis & Core Chess. Would you potentially be interested in either of those? If so let me know and we can discuss! Best, Erik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been requests for a more fine-grained identification of tournament games.
This PR introduces sub-round and sub-sub-round counters to the
Tournamentclass.It extends the simple numerical PGN "Round" tag value like
[Round "1"]to structured values, e.g.[Round "1.2.1"]. Resolves #249.Example from PGN Specification, Section 8.1.1.4:
To accomplish a more fine-grained control of openings two new policy options are introduced to
OpeningPolicy:SubRoundPolicywhich shifts openings for a new sub-round.KeepPolicywhich always keeps the same opening.There a policies to shift or not shift openings for the levels of a tournament (game, encounter, sub-round, round, tournament).
-roundsoption. Now the PGN round tag is constant for a whole cycle of sub-rounds. Those sub-rounds are numbered by the second counter. A sub-round consist of several encounters, depending on the number of players. In this PR the games within a sub-round are numbered by the sub-sub-round counter. Resolves openings policy works for gauntlet but not for round-robin (default) #641.The "round" field was changed from
inttoQStringinPgnGame.HTH