Add paths.buffer config key to redirect buffer snapshot storage#71
Open
oleg-savchenko wants to merge 1 commit into
Open
Add paths.buffer config key to redirect buffer snapshot storage#71oleg-savchenko wants to merge 1 commit into
oleg-savchenko wants to merge 1 commit into
Conversation
Mirrors the existing paths.samples pattern: if paths.buffer is set in the
config (or passed as a Hydra override), buffer snapshots are written to
{paths.buffer}/snapshots/ instead of the default {run_dir}/buffer/snapshots/.
Useful when run_dir is on a fast local filesystem but buffer snapshots
(which can be large) should land on a separate scratch volume.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
There are merge conflicts, can you please merge with the latest master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the existing paths.samples pattern: if paths.buffer is set in the config (or passed as a Hydra override), buffer snapshots are written to {paths.buffer}/snapshots/ instead of the default {run_dir}/buffer/snapshots/.
Useful when run_dir is on a fast local filesystem but buffer snapshots (which can be large) should land on a separate scratch volume.
Motivation
In HPC workflows, adaptive falcon training produces two categories of output with
very different storage requirements:
buffer/snapshots/)max_samples × field_size × adaptive_roundssamples/posterior/)graph/)paths.samplesalready allows redirecting posterior samples to a separate volume.However, buffer snapshots were hardcoded to
{run_dir}/buffer/snapshots/with nooverride, so they always landed alongside the model and config files — filling up
persistent storage with large temporary simulation data.
This PR adds a
paths.bufferconfig key — mirroring the existingpaths.samplespattern exactly — so buffer snapshots can be independently routed to scratch while
keeping
run_dir(model checkpoints, configs, logs, plots) on persistent storage.Note:
paths.bufferwas previously present as a dead/unused key and removed in75ab086. This re-adds it as a working, documented feature.
Change
falcon/cli.py— one new variable, mirrors thepaths.samplespattern: