phpcs indentation#50
Open
manishvermahbwsl wants to merge 12 commits intocyberchimps:masterfrom
manishvermahbwsl:master
Open
phpcs indentation#50manishvermahbwsl wants to merge 12 commits intocyberchimps:masterfrom manishvermahbwsl:master
manishvermahbwsl wants to merge 12 commits intocyberchimps:masterfrom
manishvermahbwsl:master
Conversation
pallavic27
reviewed
May 7, 2019
| } | ||
|
|
||
| if ( true === $plugin['force_activation'] ) { | ||
| if ( true == $plugin['force_activation'] ) { |
Contributor
There was a problem hiding this comment.
Check if phpcs mentioned to to change from === to ==
pallavic27
reviewed
May 7, 2019
includes/customizer.php
Outdated
| global $allowedposttags; | ||
| $output = wp_kses( $input, $allowedposttags); | ||
| global $allowedposttags; | ||
| $output = wp_kses( $input, $allowedposttags ); |
Contributor
There was a problem hiding this comment.
Check this function
Haer wp_kses is used. You can use this in other places
pallavic27
reviewed
May 7, 2019
|
|
||
| echo wp_kses_post( '<li class="sky-tab-content-' . $i . '"><div class="typography">' ); // echo<p>;. | ||
| foreach ( $sub as $opt ) { | ||
| echo wp_kses( $this->sub_heading( $this->parse_args( $opt ) ), responsive_allowed_html() ); |
Contributor
There was a problem hiding this comment.
Where responsive_allowed_html () written?
pallavic27
reviewed
May 7, 2019
includes/functions.php
Outdated
| ) | ||
|
|
||
| printf( | ||
| wp_kses( '<span class="%1$s">Posted on </span>%2$s<span class="%3$s"> by </span>%4$s', responsive_allowed_html() ), |
Contributor
There was a problem hiding this comment.
Here you have wp_kses with responsive_allowed_html function
Do we want to allow all html defined in in this function here?
Read https://codex.wordpress.org/Function_Reference/wp_kses for refrence
pallavic27
reviewed
May 7, 2019
includes/functions.php
Outdated
| sprintf( | ||
| '<span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s">%3$s</a></span>', | ||
| esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ), | ||
| sprintf( wp_kses( 'View all posts by %s', 'responsive' ), get_the_author() ), |
Contributor
There was a problem hiding this comment.
Second parameter not used for wp_kses
It is required
pallavic27
reviewed
May 7, 2019
includes/upsell/theme-upsell.php
Outdated
|
|
||
| <div class="theme-description"> | ||
| <p><?php echo $theme->description; ?></p> | ||
| <p><?php echo wp_kses_post( $theme->description ); ?></p> |
Contributor
There was a problem hiding this comment.
Why wp_kses_post here and esc_html on 154?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.