Fix missing action.yml in TDD Puppeteer job#4062
Merged
Merged
Conversation
Closed
…x missing action.yml Agent-Logs-Url: https://github.com/cybersemics/em/sessions/83a51777-f898-46d7-b9a1-9248d594ccf0 Co-authored-by: raineorshine <750276+raineorshine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add action.yml for Puppeteer tests
Fix missing Apr 9, 2026
action.yml in TDD Puppeteer job
raineorshine
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TDD
puppeteerjob checks out the base SHA before applying the test diff, then callsuses: ./.github/actions/serve. Ifaction.ymldidn't exist at the base SHA (e.g. it was introduced in a later PR), the step fails withCan't find 'action.yml'.Fix
After the existing
git fetchof the PR HEAD, restore.github/actions/fromFETCH_HEADbefore the composite action is needed:This ensures
action.ymlis always present at the base checkout without touching any application code (TDD validation unaffected). Theif: github.event_name == 'pull_request'guard prevents errors onworkflow_dispatchruns where no PR HEAD exists. The composite action itself is unchanged, preserving the no-duplication design from #4035.