Fix Cmd+E incorrectly triggering Extract Thought (requires Cmd+Ctrl+E)#4199
Draft
Copilot wants to merge 2 commits into
Draft
Fix Cmd+E incorrectly triggering Extract Thought (requires Cmd+Ctrl+E)#4199Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…md+E from triggering extractThought Agent-Logs-Url: https://github.com/cybersemics/em/sessions/f88837b7-0616-4c04-912c-f3ef01458c5e Co-authored-by: raineorshine <750276+raineorshine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Cmd + E activating Extract Thought command
Fix Cmd+E incorrectly triggering Extract Thought (requires Cmd+Ctrl+E)
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractThoughtis bound to{ key: 'e', control: true, meta: true }(Cmd+Ctrl+E), but Cmd+E alone was triggering it. Two bugs insrc/commands.ts:hashCommandsilently dropped thecontrolmodifier —{ key: 'e', control: true, meta: true }encoded asMETA_Einstead ofMETA_CTRL_EhashKeyDownhad no path to emitCTRL_— Cmd+E and Cmd+Ctrl+E both producedMETA_E, colliding with the aboveFix:
isMac && e.ctrlKey && e.metaKeyis intentional: on Windowse.ctrlKeyalready maps toMETA_, soCTRL_is a Mac-only concept. Requiring both keys prevents Ctrl-alone on Mac from matching Cmd+Ctrl commands.