Skip to content

chore(deps): update dependency karma-browserify to v8 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency karma-browserify to v8 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"coveralls": "^3.0.2",
"function-bind": "^1.0.2",
"karma": "^3.0.0",
"karma-browserify": "^5.0.1",
"karma-browserify": "^8.0.0",
Comment on lines 63 to +64

@graphite-app graphite-app Bot Dec 12, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade introduces a version compatibility issue. karma-browserify@8.0.0 requires karma@6.x or higher, but the project currently uses karma@3.0.0. To resolve this, either:

  1. Keep karma-browserify@5.x, or
  2. Upgrade karma to version 6.x or higher

The current combination of versions will cause runtime errors.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@MikeMcC399 MikeMcC399 Dec 12, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependencies of karma-browserify@8.0.0 are "karma": ">=4.3.0".

The graphite app did not explain why it thought that karma@6 is required. It could be true, but we don't know why.

@cursor cursor Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer dependency mismatch: karma version too old

Medium Severity

Upgrading karma-browserify to ^8.0.0 without updating karma creates a peer dependency violation. karma-browserify@8.x requires karma >= 4.3.0, but karma is still pinned to ^3.0.0 (resolving to 3.1.4). This incompatibility could cause runtime failures in the browser test suite if karma-browserify 8.x relies on APIs introduced in karma 4.x+.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ae67b65. Configure here.

"karma-cli": "^2.0.0",
"karma-coverage": "^2.0.3",
"karma-phantomjs-launcher": "^1.0.0",
Expand Down
21 changes: 13 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1466,7 +1466,7 @@ content-type@~1.0.5:
resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.5.tgz#8b773162656d1d1086784c8f23a54ce6d73d7918"
integrity sha512-nTjqfcBFEipKdXCv4YDQWCfmcLZKm81ldF0pAopTvyrFGVbcR6P/VAAd5G7N+0tTr8QqiU0tFadD6FK4NtJwOA==

convert-source-map@^1.1.3, convert-source-map@^1.7.0:
convert-source-map@^1.7.0, convert-source-map@^1.8.0:
version "1.9.0"
resolved "https://registry.yarnpkg.com/convert-source-map/-/convert-source-map-1.9.0.tgz#7faae62353fb4213366d0ca98358d22e8368b05f"
integrity sha512-ASFBup0Mz1uyiIjANan1jzLQami9z1PoYSZCiiYW2FczPbenXc45FZdBZLzOT+r6+iciuEModtmCti+hjaAk0A==
Expand Down Expand Up @@ -3844,15 +3844,15 @@ jsx-ast-utils@^1.3.4:
resolved "https://registry.yarnpkg.com/jsx-ast-utils/-/jsx-ast-utils-1.4.1.tgz#3867213e8dd79bf1e8f2300c0cfc1efb182c0df1"
integrity sha512-0LwSmMlQjjUdXsdlyYhEfBJCn2Chm0zgUBmfmf1++KUULh+JOdlzrZfiwe2zmlVJx44UF+KX/B/odBoeK9hxmw==

karma-browserify@^5.0.1:
version "5.3.0"
resolved "https://registry.yarnpkg.com/karma-browserify/-/karma-browserify-5.3.0.tgz#9001796dfd1196cbc0327b022a00c6345a28e5dd"
integrity sha512-EMaUd1RNyQVGTETI80dtX/fEtYs57/A5sl3rClvzJFImPW1s3EtsbESfqNtk7/OkzfYuAHLh4RSZSSbVgvhNdQ==
karma-browserify@^8.0.0:
version "8.1.0"
resolved "https://registry.yarnpkg.com/karma-browserify/-/karma-browserify-8.1.0.tgz#a200b15e2d93863cc704efe730722a5078b7d45b"
integrity sha512-q5OWuCfdXMfyhkRrH8XP5LiixD4lx0uCmlf6yQmGeQNHLH4Hoofur3tBJtSEhOXmY0mOdBe8ek2UUxicjmGqFQ==
dependencies:
convert-source-map "^1.1.3"
convert-source-map "^1.8.0"
hat "^0.0.3"
js-string-escape "^1.0.0"
lodash "^4.17.10"
lodash "^4.17.21"
minimatch "^3.0.0"
os-shim "^0.1.3"

Expand Down Expand Up @@ -4030,11 +4030,16 @@ lodash.memoize@~3.0.3:
resolved "https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-3.0.4.tgz#2dcbd2c287cbc0a55cc42328bd0c736150d53e3f"
integrity sha512-eDn9kqrAmVUC1wmZvlQ6Uhde44n+tXpqPrN8olQJbttgh0oKclk+SF54P47VEGE9CEiMeRwAP8BaM7UHvBkz2A==

lodash@^4.0.0, lodash@^4.0.1, lodash@^4.17.10, lodash@^4.17.20, lodash@^4.17.5, lodash@^4.3.0, lodash@^4.5.0:
lodash@^4.0.0, lodash@^4.0.1, lodash@^4.17.20, lodash@^4.17.5, lodash@^4.3.0, lodash@^4.5.0:
version "4.17.21"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==

lodash@^4.17.21:
version "4.18.1"
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.18.1.tgz#ff2b66c1f6326d59513de2407bf881439812771c"
integrity sha512-dMInicTPVE8d1e5otfwmmjlxkZoUpiVLwyeTdUsi/Caj/gfzzblBcCE5sRHV/AsjuCmxWrte2TNGSYuCeCq+0Q==

log-driver@^1.2.7:
version "1.2.7"
resolved "https://registry.yarnpkg.com/log-driver/-/log-driver-1.2.7.tgz#63b95021f0702fedfa2c9bb0a24e7797d71871d8"
Expand Down
Loading